Skip to content

fix: export TweakedPublicKey and fix JSDoc comments in bip341.d.ts #2247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: export TweakedPublicKey and fix JSDoc comments in bip341.d.ts #2247

wants to merge 1 commit into from

Conversation

VolodymyrBg
Copy link

  • Export TweakedPublicKey interface
  • Fix tapleafHash return type documentation (Buffer -> Uint8Array)
  • Clarify tweakKey hash parameter as optional

junderw
junderw requested changes Jul 20, 2025
View reviewed changes
Copy link
Member

@junderw junderw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs TS and JS changes.

In general, you should modify the TS, then run build and the d.ts file and js file will be automatically generated.

... also CI is broken... not sure why.

This was referenced Jul 24, 2025
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@junderw junderw junderw requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@VolodymyrBg @junderw